[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:355-356
+  if (addr_base == LLDB_INVALID_ADDRESS)
+    addr_base = cu_die.GetAttributeValueAsUnsigned(m_dwarf, this,
+                                                   DW_AT_GNU_addr_base, 0);
   dwo_cu->SetAddrBase(addr_base);
----------------
Do we still want the addr_base to default to zero instead of LLDB_INVALID_ADDRESS here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54751/new/

https://reviews.llvm.org/D54751