[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

[Adrian Prantl via Phabricator via lldb-commits]

aprantl added a comment.

I would like to ask a general question that I (indirectly) also asked in D54731 <https://reviews.llvm.org/D54731>: Why do we want to implement support for building inferiors in LIT-based tests? IMHO, if we need to support for dealing with specific compilers, we should implement that once in `Makefile.rules` (which is in a declarative domain-specific-language for describing build logic) and write a `dotest.py`-style test instead. I'm assuming here that we need the support in `Makefile.rules` anyway to support the bulk of the tests. Having this support in two places increases the maintenance effort and cognitive load.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54914/new/

https://reviews.llvm.org/D54914