[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

[Zachary Turner via Phabricator via lldb-commits]

zturner updated this revision to Diff 174473.
zturner added a comment.
Herald added a subscriber: ki.stfu.

- Added an `__init__.py` to the helper directory.  This is required on Python 2 to make the import work.
- Changed a bunch of `%cc` substitutions to `%clang`.
- Changed the `%clang_cl` command lines to always pass /c.  This fixes an issue where we are unable to automatically locate the installed Visual Studio when running from inside of VS.

After this patch, the test run is clean on OSX and awaiting word on whether it's clean on Windows (it is for me).

Thanks to @stella.stamenova for the help.


https://reviews.llvm.org/D54567

Files:
  clang/test/lit.cfg.py
  lldb/lit/Breakpoint/case-insensitive.test
  lldb/lit/Breakpoint/case-sensitive.test
  lldb/lit/Expr/TestIRMemoryMap.test
  lldb/lit/Expr/TestIRMemoryMapWindows.test
  lldb/lit/Quit/TestQuitExitCode-30.test
  lldb/lit/Quit/TestQuitExitCode30.test
  lldb/lit/Quit/TestQuitExitCodeHexA.test
  lldb/lit/SymbolFile/DWARF/apple-index-is-used.cpp
  lldb/lit/SymbolFile/DWARF/debug-names-compressed.cpp
  lldb/lit/SymbolFile/DWARF/dwarf5-index-is-used.cpp
  lldb/lit/SymbolFile/DWARF/dwarf5-partial-index.cpp
  lldb/lit/SymbolFile/DWARF/find-basic-function.cpp
  lldb/lit/SymbolFile/DWARF/find-basic-namespace.cpp
  lldb/lit/SymbolFile/DWARF/find-basic-type.cpp
  lldb/lit/SymbolFile/DWARF/find-basic-variable.cpp
  lldb/lit/SymbolFile/DWARF/find-function-regex.cpp
  lldb/lit/SymbolFile/DWARF/find-method-local-struct.cpp
  lldb/lit/SymbolFile/DWARF/find-method.cpp
  lldb/lit/SymbolFile/DWARF/find-qualified-variable.cpp
  lldb/lit/SymbolFile/DWARF/find-type-in-function.cpp
  lldb/lit/SymbolFile/DWARF/find-variable-dwo.cpp
  lldb/lit/SymbolFile/DWARF/find-variable-file.cpp
  lldb/lit/SymbolFile/NativePDB/ast-reconstruction.cpp
  lldb/lit/SymbolFile/NativePDB/bitfields.cpp
  lldb/lit/SymbolFile/NativePDB/disassembly.cpp
  lldb/lit/SymbolFile/NativePDB/function-types-builtins.cpp
  lldb/lit/SymbolFile/NativePDB/function-types-calling-conv.cpp
  lldb/lit/SymbolFile/NativePDB/function-types-classes.cpp
  lldb/lit/SymbolFile/NativePDB/global-classes.cpp
  lldb/lit/SymbolFile/NativePDB/globals-bss.cpp
  lldb/lit/SymbolFile/NativePDB/globals-fundamental.cpp
  lldb/lit/SymbolFile/NativePDB/nested-types.cpp
  lldb/lit/SymbolFile/NativePDB/s_constant.cpp
  lldb/lit/SymbolFile/NativePDB/simple-breakpoints.cpp
  lldb/lit/SymbolFile/NativePDB/source-list.cpp
  lldb/lit/SymbolFile/NativePDB/tag-types.cpp
  lldb/lit/SymbolFile/PDB/ast-restore.test
  lldb/lit/SymbolFile/PDB/calling-conventions.test
  lldb/lit/SymbolFile/PDB/class-layout.test
  lldb/lit/SymbolFile/PDB/compilands.test
  lldb/lit/SymbolFile/PDB/enums-layout.test
  lldb/lit/SymbolFile/PDB/func-symbols.test
  lldb/lit/SymbolFile/PDB/function-level-linking.test
  lldb/lit/SymbolFile/PDB/function-nested-block.test
  lldb/lit/SymbolFile/PDB/pointers.test
  lldb/lit/SymbolFile/PDB/type-quals.test
  lldb/lit/SymbolFile/PDB/typedefs.test
  lldb/lit/SymbolFile/PDB/udt-layout.test
  lldb/lit/SymbolFile/PDB/variables-locations.test
  lldb/lit/SymbolFile/PDB/variables.test
  lldb/lit/SymbolFile/PDB/vbases.test
  lldb/lit/helper/__init__.py
  lldb/lit/helper/toolchain.py
  lldb/lit/lit.cfg.py
  lldb/lit/lit.site.cfg.py.in
  lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test
  lldb/lit/tools/lldb-mi/breakpoint/break-insert.test
  lldb/lit/tools/lldb-mi/data/data-info-line.test
  lldb/lit/tools/lldb-mi/exec/exec-continue.test
  lldb/lit/tools/lldb-mi/exec/exec-finish.test
  lldb/lit/tools/lldb-mi/exec/exec-interrupt.test
  lldb/lit/tools/lldb-mi/exec/exec-next-instruction.test
  lldb/lit/tools/lldb-mi/exec/exec-next.test
  lldb/lit/tools/lldb-mi/exec/exec-step-instruction.test
  lldb/lit/tools/lldb-mi/exec/exec-step.test
  lldb/lit/tools/lldb-mi/symbol/symbol-list-lines.test
  lldb/lit/tools/lldb-mi/target/target-select-so-path.test
  lldb/test/CMakeLists.txt
  llvm/utils/lit/lit/TestingConfig.py
  llvm/utils/lit/lit/llvm/config.py
  llvm/utils/lit/lit/llvm/subst.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54567.174473.patch
Type: text/x-patch
Size: 66243 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181117/7690ba1c/attachment-0001.bin>