[Lldb-commits] [PATCH] D54476: [CMake] Streamline code signing for debugserver

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 15 09:09:53 PST 2018


labath added inline comments.


================
Comment at: tools/debugserver/source/CMakeLists.txt:101
+option(LLDB_NO_DEBUGSERVER "Delete debugserver after building it, and don't try to codesign it" OFF)
+option(LLDB_USE_SYSTEM_DEBUGSERVER "Neither build nor codesign debugserver. Use the system's debugserver instead (Darwin only)." OFF)
+
----------------
sgraenitz wrote:
> JDevlieghere wrote:
> > Should we emit and error if these variables are in an inconsistent state, e.g. when both are set? 
> Yes, could do that.
Alternatively, we could make this a single tri-state variable. `LLDB_DEBUGSERVER_MODE=OFF|SYSTEM|TREE` or something ?


https://reviews.llvm.org/D54476





More information about the lldb-commits mailing list