[Lldb-commits] [PATCH] D44081: [lldb] Add synthetic frontend for _NSCallStackArray

Kuba (Brecka) Mracek via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 12 09:19:19 PST 2018


kubamracek marked an inline comment as done.
kubamracek added inline comments.


================
Comment at: source/Plugins/Language/ObjC/NSArray.cpp:446-451
+  } else if (class_name == g_NSCallStackArray) {
+    Status error;
+    value = process_sp->ReadUnsignedIntegerFromMemory(
+        valobj_addr + 2 * ptr_size, ptr_size, 0, error);
+    if (error.Fail())
+      return false;
----------------
davide wrote:
> Can you add a comment here?
> this also seems exactly the same as `NSArrayCF`, any chance we can avoid the duplication?
Added comment and de-duplicated the branch.


https://reviews.llvm.org/D44081





More information about the lldb-commits mailing list