[Lldb-commits] [PATCH] D54352: [CMake] Explicit lldb_codesign function with application in debugserver and lldb-server

Stefan Gränitz via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Nov 9 13:56:53 PST 2018

sgraenitz added a comment.

This would soon be used for other targets as well. llvm_codesign is here: https://reviews.llvm.org/D48797

Comment at: cmake/modules/AddLLDB.cmake:212
+      set(pass_force "--force")
+    endif()
So far `--force` was used everywhere to avoid trouble with double signing I guess (turns the error into a warning). IIUC this should never happen for a post-build action right? Thus, the "more correct" way may be to remove this from invocations/altogether and go fix the actual issue if it ever fails. But then I think, who wants to bother with double code signing issues..

Anyway, llvm_codesign doesn't force. Any good reason to keep it?


More information about the lldb-commits mailing list