[Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

Stella Stamenova via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 6 09:36:19 PST 2018

stella.stamenova added a comment.

In https://reviews.llvm.org/D54009#1284839, @zturner wrote:

> In https://reviews.llvm.org/D54009#1284827, @stella.stamenova wrote:
> > Looks good. The formatting in lit.cfg.py is a bit messy (indentations, especially), but as long as the tests pass, this is an improvement :). Thanks!
> Is there something like clang-format for Python?  Happy to fix it if so.  (I don't do a lot of Python so it's hard for me to eyeball it and figure out what's wrong, so I have to say it looks fine to me :))

There's no clang-format for Python that I know of. Since python cares about indentation, it's always a good idea to make sure that we use the same number of spaces for all of the 'if's and such as it will occasionally lead to hard to track down bugs. There are (in the final version) of lit.cfg.py a couple of places where two spaces make the indentation and everything else uses four. It's not a big deal because of where they are, but something to look out for.



More information about the lldb-commits mailing list