[Lldb-commits] [PATCH] D54074: CPlusPlusLanguage: Use new demangler API to implement type substitution
Stefan Gränitz via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Nov 5 05:26:23 PST 2018
sgraenitz added a comment.
Hi Pavel, thanks for working on this. The code looks really great. I have no actual concerns about landing it like this.
Two minor remarks:
- We still have no coverage for substitution failures in `CPlusPlusLanguageTest.cpp` test case `FindAlternateFunctionManglings`.
- We create a new `BumpPtrAllocator` for each `TypeSubstitutor::substitute()`, right? Well, the impact on performance is probably on a different order of magnitude than we are concerned about here.
> This will allow us to remove the specialized hooks which were added to the demangler to support this use case.
Right, it bridged the time between removing FastDemangle from LLDB and getting the new ManglingParser in LLVM. IIUC this basically means reverting https://reviews.llvm.org/D50586.
More information about the lldb-commits