[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

Aleksandr Urakov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sat Nov 3 14:21:08 PDT 2018

aleksandr.urakov reopened this revision.
aleksandr.urakov added a comment.
This revision is now accepted and ready to land.

@davide You are right, this patch was the cause of the failure, sorry for that. It seems that I've found a generic issue with this patch. Thanks again for pointing to that!

@clayborg The problem is that there is a bunch of places where a symtab is retrieved directly from an object file, not from a symbol vendor. So it remains uncalculated. If we will just return the recalculation / finalization to object files, it will fix the issue, but symbols from PDB will not be available in this places. We can try to use the symbol vendor instead everywhere in this places (we can retrieve a module from an object file, and we can retrieve a symbol vendor from a module, so it is guaranteed that we can get the symbol vendor in all these places). What do you think about the such approach? What pitfalls can be with it?



More information about the lldb-commits mailing list