[Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files

[Zachary Turner via Phabricator via lldb-commits]

zturner created this revision.
zturner added reviewers: stella.stamenova, labath, beanz, davide.
Herald added subscribers: jfb, delcypher, mgorny, ki.stfu.

A year or so ago, I re-wrote most of the lit infrastructure in LLVM so that it wasn't so boilerplate-y.  I added lots of common helper type stuff, simplifed usage patterns, and made the code more elegant and maintainable.

We migrated to this in LLVM, clang, and lld's lit files, but not in LLDBs.  This started to bite me recently, as the 4 most recent times I tried to run the lit test suite in LLDB on a fresh checkout the first thing that would happen is that python would just start crashing with unhelpful backtraces and I would have to spend time investigating.

You can reproduce this today by doing a fresh cmake generation, doing `ninja lldb` and then `python bin/llvm-lit.py -sv ~/lldb/lit/SymbolFile` at which point you'll get a segfault that tells you nothing about what your problem is.

I started trying to fix the issues with bandaids, but it became clear that the proper solution was to just bring in the work I did in the rest of the projects.  The side benefit of this is that the lit configuration files become much cleaner and more understandable as a result.


https://reviews.llvm.org/D54009

Files:
  lldb/lit/Breakpoint/case-insensitive.test
  lldb/lit/Breakpoint/lit.local.cfg
  lldb/lit/CMakeLists.txt
  lldb/lit/Expr/TestIRMemoryMapWindows.test
  lldb/lit/Expr/lit.local.cfg
  lldb/lit/Quit/lit.local.cfg
  lldb/lit/Settings/lit.local.cfg
  lldb/lit/SymbolFile/NativePDB/lit.local.cfg
  lldb/lit/SymbolFile/PDB/ast-restore.test
  lldb/lit/SymbolFile/PDB/calling-conventions.test
  lldb/lit/SymbolFile/PDB/class-layout.test
  lldb/lit/SymbolFile/PDB/compilands.test
  lldb/lit/SymbolFile/PDB/enums-layout.test
  lldb/lit/SymbolFile/PDB/func-symbols.test
  lldb/lit/SymbolFile/PDB/function-level-linking.test
  lldb/lit/SymbolFile/PDB/function-nested-block.test
  lldb/lit/SymbolFile/PDB/lit.local.cfg
  lldb/lit/SymbolFile/PDB/pointers.test
  lldb/lit/SymbolFile/PDB/type-quals.test
  lldb/lit/SymbolFile/PDB/typedefs.test
  lldb/lit/SymbolFile/PDB/udt-layout.test
  lldb/lit/SymbolFile/PDB/variables-locations.test
  lldb/lit/SymbolFile/PDB/variables.test
  lldb/lit/Unit/lit.cfg
  lldb/lit/Unit/lit.cfg.py
  lldb/lit/Unit/lit.site.cfg.in
  lldb/lit/Unit/lit.site.cfg.py.in
  lldb/lit/lit.cfg
  lldb/lit/lit.cfg.py
  lldb/lit/lit.site.cfg.in
  lldb/lit/lit.site.cfg.py.in
  lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test
  lldb/lit/tools/lldb-mi/breakpoint/break-insert.test
  lldb/lit/tools/lldb-mi/data/data-info-line.test
  lldb/lit/tools/lldb-mi/exec/exec-continue.test
  lldb/lit/tools/lldb-mi/exec/exec-finish.test
  lldb/lit/tools/lldb-mi/exec/exec-interrupt.test
  lldb/lit/tools/lldb-mi/exec/exec-next-instruction.test
  lldb/lit/tools/lldb-mi/exec/exec-next.test
  lldb/lit/tools/lldb-mi/exec/exec-step-instruction.test
  lldb/lit/tools/lldb-mi/exec/exec-step.test
  lldb/lit/tools/lldb-mi/symbol/symbol-list-lines.test
  llvm/utils/lit/lit/llvm/config.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54009.172254.patch
Type: text/x-patch
Size: 28842 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181101/a65511ed/attachment-0001.bin>