[Lldb-commits] [PATCH] D53989: Fix formatting of wchar, char16, and char32

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 1 15:17:50 PDT 2018

jingham added a comment.

Note also, the vast majority of the uses of LLDB_DISABLE_PYTHON are related to the requirement that we have Python to use any of the data formatter facilities.  Those uses shouldn't be necessary.  All the scripted interpreters should go through the generic ScriptInterpreter interface.  There's a ScriptInterpreterNone that should stand in for the Python interpreter in every use except directly managing the Python interpreter.  So there's no structural reason why we should need LLDB_DISABLE_PYTHON for anything but the initializers.  We should just be able to not build the *Python.cpp files and use the define only to not initialize the Python script interpreter.  Something got balled up in how the data formatters were implemented that this isn't true, IMHO.

If somebody wants to spend time looking at this, figuring how to untangle this would serve your purposes and also get the architecture back right at the same time.


More information about the lldb-commits mailing list