[Lldb-commits] [PATCH] D53989: Fix formatting of wchar, char16, and char32

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 1 14:17:28 PDT 2018


jingham added a comment.

So the deal is that we were relying on a summary formatter to print wchar_t before, and now you have a format option that handles them as well?  Do we need both? Maybe the summary also handles wchar_t * strings?

As an aside, for reasons that are not entirely clear to me most of the data formatter code is #ifndef LLDB_DISABLE_PYTHON.  That shouldn't be true, C++ based formatters (which all the built-in formatters are) should be able to work in the absence of Python.  Figuring out why this is true is on my list of things to investigate some spare afternoon...


https://reviews.llvm.org/D53989





More information about the lldb-commits mailing list