[Lldb-commits] [PATCH] D53834: [FileSystem] Remove ResolveExecutableLocation() from FileSpec

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 1 09:01:35 PDT 2018


JDevlieghere added a comment.

In https://reviews.llvm.org/D53834#1281822, @labath wrote:

> Why did you change the function name? I think it would be nice to keep "executable" or something to that effect in the name (e.g. the llvm function has "program"), given that the underlying function checks for the executable bit, and so it cannot be used for general searches.


Yep you're right, this wasn't clear from the doxygen but I should've checked the llvm implementation.


https://reviews.llvm.org/D53834





More information about the lldb-commits mailing list