[Lldb-commits] [lldb] r345711 - [lldb] Fix race condition in framework installation

Shoaib Meenai via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 31 03:41:12 PDT 2018

Author: smeenai
Date: Wed Oct 31 03:41:12 2018
New Revision: 345711

URL: http://llvm.org/viewvc/llvm-project?rev=345711&view=rev
[lldb] Fix race condition in framework installation

We need the install-liblldb-stripped target to depend on the
lldb-framework target in order for the installation to be guaranteed to
behave correctly, otherwise it's possible for the lldb-framework and
install-liblldb-stripped targets to run in parallel, resulting in
temporary or partially processed files being copied into the framework.
install-liblldb already depends on lldb-framework for this reason.

Differential Revision: https://reviews.llvm.org/D53917


Modified: lldb/trunk/cmake/modules/AddLLDB.cmake
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/cmake/modules/AddLLDB.cmake?rev=345711&r1=345710&r2=345711&view=diff
--- lldb/trunk/cmake/modules/AddLLDB.cmake (original)
+++ lldb/trunk/cmake/modules/AddLLDB.cmake Wed Oct 31 03:41:12 2018
@@ -79,7 +79,7 @@ function(add_lldb_library name)
         # framework, so it must rely on the framework being fully built first.
         if (LLDB_BUILD_FRAMEWORK AND ${name} STREQUAL "liblldb")
           add_dependencies(install-${name} lldb-framework)
-          add_dependencies(install-lldb-framework-stripped lldb-framework)
+          add_dependencies(install-${name}-stripped lldb-framework)

More information about the lldb-commits mailing list