[Lldb-commits] [PATCH] D53917: [lldb] Fix race condition in framework installation

[Shoaib Meenai via Phabricator via lldb-commits]

smeenai created this revision.
smeenai added a reviewer: xiaobai.
Herald added a subscriber: mgorny.

We need the install-liblldb-stripped target to also depend on the
llvm-framework target in order for the installation to be guaranteed to
behave as intended. I believe this is simply a typo.


https://reviews.llvm.org/D53917

Files:
  cmake/modules/AddLLDB.cmake


Index: cmake/modules/AddLLDB.cmake
===================================================================
--- cmake/modules/AddLLDB.cmake
+++ cmake/modules/AddLLDB.cmake
@@ -79,7 +79,7 @@
         # framework, so it must rely on the framework being fully built first.
         if (LLDB_BUILD_FRAMEWORK AND ${name} STREQUAL "liblldb")
           add_dependencies(install-${name} lldb-framework)
-          add_dependencies(install-lldb-framework-stripped lldb-framework)
+          add_dependencies(install-${name}-stripped lldb-framework)
         endif()
       endif()
     endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53917.171854.patch
Type: text/x-patch
Size: 581 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181031/0b36a2c8/attachment.bin>