[Lldb-commits] [PATCH] D53915: [FileSystem] Move resolve logic out of FileSpec

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: labath, zturner, davide.
JDevlieghere added a project: LLDB.
Herald added subscribers: teemperor, jfb, arichardson, emaste.
Herald added a reviewer: espindola.

This patch removes the logic for resolving paths out of `FileSpec` and updates call sites to rely on the FileSystem class instead.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53915

Files:
  include/lldb/Target/Process.h
  include/lldb/Utility/FileSpec.h
  source/API/SBAttachInfo.cpp
  source/API/SBDebugger.cpp
  source/API/SBFileSpec.cpp
  source/API/SBHostOS.cpp
  source/API/SBLaunchInfo.cpp
  source/API/SBModuleSpec.cpp
  source/API/SBPlatform.cpp
  source/API/SBProcess.cpp
  source/API/SBTarget.cpp
  source/Breakpoint/BreakpointResolverAddress.cpp
  source/Breakpoint/BreakpointResolverFileLine.cpp
  source/Commands/CommandCompletions.cpp
  source/Commands/CommandObjectBreakpoint.cpp
  source/Commands/CommandObjectCommands.cpp
  source/Commands/CommandObjectLog.cpp
  source/Commands/CommandObjectMemory.cpp
  source/Commands/CommandObjectPlatform.cpp
  source/Commands/CommandObjectPlugin.cpp
  source/Commands/CommandObjectProcess.cpp
  source/Commands/CommandObjectSettings.cpp
  source/Commands/CommandObjectSource.cpp
  source/Commands/CommandObjectTarget.cpp
  source/Commands/CommandObjectThread.cpp
  source/Core/Debugger.cpp
  source/Core/DynamicLoader.cpp
  source/Core/Module.cpp
  source/Core/ModuleList.cpp
  source/Core/PluginManager.cpp
  source/Core/SearchFilter.cpp
  source/Expression/REPL.cpp
  source/Host/common/Editline.cpp
  source/Host/common/File.cpp
  source/Host/common/FileSystem.cpp
  source/Host/common/Host.cpp
  source/Host/common/HostInfoBase.cpp
  source/Host/common/MonitoringProcessLauncher.cpp
  source/Host/common/Symbols.cpp
  source/Host/macosx/Symbols.cpp
  source/Host/macosx/objcxx/Host.mm
  source/Host/macosx/objcxx/HostInfoMacOSX.mm
  source/Host/posix/FileSystem.cpp
  source/Host/posix/HostInfoPosix.cpp
  source/Host/posix/HostProcessPosix.cpp
  source/Interpreter/CommandInterpreter.cpp
  source/Interpreter/OptionValueFileSpec.cpp
  source/Interpreter/OptionValueFileSpecLIst.cpp
  source/Interpreter/Options.cpp
  source/Interpreter/Property.cpp
  source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp
  source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.cpp
  source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp
  source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp
  source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp
  source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp
  source/Plugins/ExpressionParser/Clang/ClangHost.cpp
  source/Plugins/JITLoader/GDB/JITLoaderGDB.cpp
  source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp
  source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp
  source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp
  source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
  source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
  source/Plugins/Platform/Android/PlatformAndroid.cpp
  source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp
  source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.cpp
  source/Plugins/Platform/MacOSX/PlatformAppleWatchSimulator.cpp
  source/Plugins/Platform/MacOSX/PlatformDarwin.cpp
  source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp
  source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp
  source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.cpp
  source/Plugins/Platform/MacOSX/PlatformiOSSimulator.cpp
  source/Plugins/Platform/MacOSX/objcxx/PlatformiOSSimulatorCoreSimulatorSupport.mm
  source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
  source/Plugins/Platform/Windows/PlatformWindows.cpp
  source/Plugins/Process/elf-core/ProcessElfCore.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  source/Plugins/Process/minidump/ProcessMinidump.cpp
  source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
  source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp
  source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
  source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
  source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
  source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
  source/Plugins/SymbolVendor/ELF/SymbolVendorELF.cpp
  source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp
  source/Plugins/SystemRuntime/MacOSX/SystemRuntimeMacOSX.cpp
  source/Symbol/CompileUnit.cpp
  source/Symbol/ObjectFile.cpp
  source/Symbol/Symbol.cpp
  source/Symbol/SymbolContext.cpp
  source/Target/ModuleCache.cpp
  source/Target/PathMappingList.cpp
  source/Target/Platform.cpp
  source/Target/Process.cpp
  source/Target/ProcessInfo.cpp
  source/Target/ProcessLaunchInfo.cpp
  source/Target/TargetList.cpp
  source/Utility/FileSpec.cpp
  tools/lldb-server/lldb-gdbserver.cpp
  tools/lldb-server/lldb-platform.cpp
  tools/lldb-test/lldb-test.cpp
  unittests/Core/MangledTest.cpp
  unittests/Expression/ClangParserTest.cpp
  unittests/Host/FileSystemTest.cpp
  unittests/Host/SymbolsTest.cpp
  unittests/ObjectFile/ELF/TestObjectFileELF.cpp
  unittests/Platform/PlatformDarwinTest.cpp
  unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp
  unittests/Symbol/TestDWARFCallFrameInfo.cpp
  unittests/SymbolFile/DWARF/SymbolFileDWARFTests.cpp
  unittests/Target/ModuleCacheTest.cpp
  unittests/Target/PathMappingListTest.cpp
  unittests/Utility/FileSpecTest.cpp
  unittests/Utility/StructuredDataTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53915.171843.patch
Type: text/x-patch
Size: 188348 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181031/75d2b0d6/attachment-0001.bin>