[Lldb-commits] [PATCH] D53788: [FileSystem] Remove GetByteSize() from FileSpec

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 29 09:22:30 PDT 2018

JDevlieghere added a comment.

In https://reviews.llvm.org/D53788#1278036, @zturner wrote:

> I always wondered if we actually even need methods like this in `FileSystem` given that they already exist in `llvm::sys::fs`.  Is it possible to just call the llvm methods directly, or is it still helpful to call the ones in `FileSystem` so we can more transparently interoperate with the VFS layer somehow?

This particular function uses the VFS so it has to go through the `FileSystem` class. Personally I feel we should do the same for functions that don't, because then it's clear and simple (i.e. everything uses `FileSystem`) and we eliminate potential bugs where someone uses the `llvm::sys::fs` while it should've actually gone through the VFS.



More information about the lldb-commits mailing list