[Lldb-commits] [PATCH] D52618: [Windows] A basic implementation of memory allocations in a debuggee process

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 29 07:15:44 PDT 2018

On 29/10/18 15:06, Zachary Turner wrote:
> Even in this exact case we have the multiple variants situation. If we
> use the substitutions method we would reduce the test coverage by half,
> which doesn’t seem like a good idea.

Which variants do you have in mind? This patch creates two tests: one
which has REQUIRES: windows, and another which has UNSUPPORTED: windows.
With the substitution we would have just one test, which runs everywhere
(but tests slightly different things).

> Similarly, in the target variables tests i added to the native pdb
> plugin Jim was asking if I could also enable that exact same test for
> other platforms. But it’s not possible without a way to run multiple
> variants. And for tests where no running process is required I think
> it’s a worthy goal to try to do that.

I certainly don't disagree with that, but I think there may be room for
both approaches.

More information about the lldb-commits mailing list