[Lldb-commits] [PATCH] D52618: [Windows] A basic implementation of memory allocations in a debuggee process

Aleksandr Urakov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 29 02:29:16 PDT 2018

aleksandr.urakov added a comment.

In https://reviews.llvm.org/D52618#1278442, @zturner wrote:

> Is this still blocked on anything?

It seems that it's not blocked on anything. The test, as you have mentioned in the earlier message, is already duplicating only `RUN: lldb-test` lines, there are no check files used here.

Comment at: source/Plugins/Process/Windows/Common/ProcessWindows.cpp:712
+lldb::addr_t ProcessWindows::DoAllocateMemory(size_t size, uint32_t permissions,
+                                              Status &error) {
Hui wrote:
> Looks to me they are handlers to the GDB remote "__m" and "__M" packets.  If the remote is on Windows host, the debug inferior shall be responsible to handle memory allocation/deallocation for JITed codes. (There is a process utility for InferiorCall). Otherwise,  the requests will be answered by remote gdb server with memory region returned.
No, they are not, it's not an lldb-server plugin, it's a native Windows process plugin.


More information about the lldb-commits mailing list