[Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

Stella Stamenova via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 26 10:21:34 PDT 2018

stella.stamenova accepted this revision.
stella.stamenova added a comment.
This revision is now accepted and ready to land.

A couple of comments, but looks good otherwise. I'd wait for someone else to have a look as well.

Comment at: source/Plugins/Process/Windows/Common/ProcessWindows.cpp:959
+    // It may be an expression evaluation crash.
+    SetPrivateState(eStateStopped);
Are we going to determine later whether it is supposed to be a crash or just never crash on second chance exceptions?

Comment at: source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:1085
+  } else
+    set = &m_namespaces;
+  assert(set);
Nit: Maybe add curly braces here. Since the if statement has them, the code is easier to read if the else does as well.



More information about the lldb-commits mailing list