[Lldb-commits] [PATCH] D53749: [PDB] Fix `SymbolFilePDBTests` after r345313

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 26 02:21:38 PDT 2018

zturner added a subscriber: aleksandr.urakov.
zturner added a comment.

Ahh, I meant to remind you, because I noticed this when I was looking
through the SymbolFilePDB code recently.  I think the LLVM guideline is not
to use so much auto.  The generally accepted rule is that we can use for
the result of make_shared, make_unique, and result of iterator types, but
otherwise we prefer to explicitly spell the types out.  You don't have to
go and submit another patch on top of this one to fix it again, it's just
something to keep in mind.

That said, thanks for fixing this for me.  Sorry for the break.



More information about the lldb-commits mailing list