[Lldb-commits] [PATCH] D53731: [NativePDB] Add the ability to display global variables
Zachary Turner via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Oct 26 01:22:59 PDT 2018
zturner added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:913
+ uint32_t section_idx = section - 1;
+ if (section_idx >= section_list->GetSize())
> lemo wrote:
> > comment explaining the - 1 ?
> I'm going to be totally honest here. I don't understand this code at all. I copied it from the `SymbolFilePDB` implementation. It seems to work :-/
Ok, I thought about this some, it's actually pretty simple. I'll add a comment.
More information about the lldb-commits