[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 25 11:15:47 PDT 2018

clayborg added a comment.

In https://reviews.llvm.org/D53368#1276152, @aleksandr.urakov wrote:

> Yes, I'll implement it tomorrow (I'm already OOO now), thanks. But is it really necessary to check the number of symbols added if we must to calculate / finalize the symtab after getting it from object file anyway? May be just always do it after creation and processing by the symbol file? For each symtab it will be done just once because of caching.

yes, fine to still have void and always call symtab.CalculateSymbolSizes(); and symtab.Finalize() only in the symbol vendor. Find the other places this is called in the ObjectFile plug-ins and remove them and do them once in Symbol vendor when we fetch the symtab for the first time


More information about the lldb-commits mailing list