[Lldb-commits] [PATCH] D53597: Don't type-erase the SymbolContextItem enum

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 25 11:12:09 PDT 2018

zturner added a comment.

In https://reviews.llvm.org/D53597#1276145, @jingham wrote:

> So far as I can tell, this patch will make lookup of exact types faster for PDB, but because of the way DWARF debug_names tables are constructed, I don't think there's any way we can do the same thing for DWARF.
> But unless I'm misunderstanding the patch, this doesn't change correctness of the lookup (except for fixing "type lookup 'struct Foo'").  Did I miss something?
> Jim

That's the other patch.  This patch is NFC and just makes debugging nicer because you can see enum values in your debugger as rich enumerators.  But for the other patch, if what you said is correct, then I suppose that's correct.  I asked Eric Christopher and he said he thought (but wasn't 100% sure) that types were hashed in the accelerator tables by their full name and not their base name.  If that is true then it could make exact matches faster.  But if it's incorrect then yes, it wouldn't be able to make exact matches faster in DWARF.


More information about the lldb-commits mailing list