[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 25 10:42:19 PDT 2018

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Very close, just down to making the SymbolVendor::GetSymtab() call symtab.CalculateSymbolSizes() and symtab.Finalize().

Comment at: source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp:1382-1383
+  symtab.CalculateSymbolSizes();
+  symtab.Finalize();
Seems like these two lines should be done in the symbol vendor? Maybe this function should return the number of symbols added and the symbol vendor could see if AddSymbols returns a positive number, and if so, call symtab.CalculateSymbolSizes() and symtab.Finalize(). We should also see who else is calling these and remove any calls and only do it in the SymbolVendor one time.


More information about the lldb-commits mailing list