[Lldb-commits] [PATCH] D53532: [FileSpec] Add VFS support to FileSpec convenience methods.

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 24 22:00:56 PDT 2018

Sent from my iPhone

> On Oct 24, 2018, at 7:05 PM, Zachary Turner <zturner at google.com> wrote:
> It seems like FileSpec was moved out of Utility and into Host. I’m not a fan of this change, because it took a lot of effort to get it into Utility, which helped break a lot of bad dependencies. Can we invert this dependency and move FileSpec back into Utility?
>> On Wed, Oct 24, 2018 at 5:53 PM Jonas Devlieghere via Phabricator <reviews at reviews.llvm.org> wrote:
>> JDevlieghere added a comment.
>> Note that there's also a File class which we'll need to patch up separately together with all other uses that actually open or read a file. For this class we can do the same as we did for FileSpec: deferring relevant operations to the FileSystem class.
>> https://reviews.llvm.org/D53532
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181024/00913973/attachment.html>

More information about the lldb-commits mailing list