[Lldb-commits] [PATCH] D52651: Add functionality to export settings
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Oct 24 16:23:52 PDT 2018
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
Sorry, this somehow didn't show up in my review queue. I think this can land after two minor things are fixed:
- I think unknown arguments to write/read shouldn't be silently ignored.
- And I think we should report an error if writing to the output file fails.
To give a practical example: This command below fails to write to the output file but also doesn't produce any error message.
`settings write -f ~/ foo`
Note that there is a space behind the /, so we write to a directory (which fails) and we silently ignore the second unknown arg.
More information about the lldb-commits