[Lldb-commits] [PATCH] D47889: Use llvm::VersionTuple instead of manual version marshalling

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 24 14:43:10 PDT 2018

aprantl added a comment.

Just FYI, I just came across this patch while debugging strangeness in PlatformDarwin.cpp and unfortunately this patch isn't NFC. `VersionTuple::tryParse()` can deal with an optional third (micro) component, but the parse will fail when there are extra characters after the version number (in my case trying to parse the substring "12.0.sdk" out of "iPhoneSimulator12.0.sdk" now fails after this patch). I'll fix it and try to add a unit test ...



More information about the lldb-commits mailing list