[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

Leonard Mosescu via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 24 11:39:13 PDT 2018

lemo added a comment.

drive by CR notes:

1. does this handle forwarding imports? (it doesn't seem to from a quick glance at the code)
2. can you please add, or extend the existing test to cover the transitive case? A simple dag would suffice (ex. make both dllA and dllB implicitly import dllC)

Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h:219
     coff_data_dir_import_table = 1,
+    coff_data_dir_resource_table,
+    coff_data_dir_exception_table,
nit: either explicitly assign values to all or none


More information about the lldb-commits mailing list