[Lldb-commits] [lldb] r345091 - Fix some comments pointed out by Leonard Mosescu.

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 23 15:15:05 PDT 2018


Author: zturner
Date: Tue Oct 23 15:15:05 2018
New Revision: 345091

URL: http://llvm.org/viewvc/llvm-project?rev=345091&view=rev
Log:
Fix some comments pointed out by Leonard Mosescu.

These were originally pointed out in D53511 but I forgot
to incorporate them in my patch.

Modified:
    lldb/trunk/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp

Modified: lldb/trunk/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp?rev=345091&r1=345090&r2=345091&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp Tue Oct 23 15:15:05 2018
@@ -310,7 +310,7 @@ static llvm::StringRef GetSimpleTypeName
     return "char";
   case SimpleTypeKind::SignedCharacter:
   case SimpleTypeKind::SByte:
-    return "signed chr";
+    return "signed char";
   case SimpleTypeKind::Character16:
     return "char16_t";
   case SimpleTypeKind::Character32:
@@ -332,7 +332,7 @@ static llvm::StringRef GetSimpleTypeName
     return "__int128";
   case SimpleTypeKind::Int64:
   case SimpleTypeKind::Int64Quad:
-    return "__int64";
+    return "int64_t";
   case SimpleTypeKind::Int32:
     return "int";
   case SimpleTypeKind::Int16:
@@ -341,7 +341,7 @@ static llvm::StringRef GetSimpleTypeName
     return "unsigned __int128";
   case SimpleTypeKind::UInt64:
   case SimpleTypeKind::UInt64Quad:
-    return "unsigned __int64";
+    return "uint64_t";
   case SimpleTypeKind::HResult:
     return "HRESULT";
   case SimpleTypeKind::UInt32:
@@ -644,7 +644,7 @@ lldb::TypeSP SymbolFileNativePDB::Create
     TypeSP direct_sp = GetOrCreateType(ti.makeDirect());
     CompilerType ct = direct_sp->GetFullCompilerType();
     ct = ct.GetPointerType();
-    uint32_t pointer_size = 4;
+    uint32_t pointer_size = 0;
     switch (ti.getSimpleMode()) {
     case SimpleTypeMode::FarPointer32:
     case SimpleTypeMode::NearPointer32:




More information about the lldb-commits mailing list