[Lldb-commits] [PATCH] D53590: Refactor SetBaseClassesForType and DeleteBaseClasses to be more C++'y
Zachary Turner via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Oct 23 13:08:29 PDT 2018
zturner added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3273-3274
+ is_virtual, is_base_of_class);
+ if (!result)
> If the result is a `nullptr`, then there is no base to begin with. This indicates an error, so continuing doesn't make sense. In fact, I think this was a bug with the previous implementation. We were pushing back a null base onto the list of base classes. I suspect it never actually happened in practice, though.
One alternative would be to assert that it is *not* null, then continue as the previous code did. WDYT?
More information about the lldb-commits