[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

[Alexander Polyakov via Phabricator via lldb-commits]

apolyakov added a comment.

I think that it's worth it to rewrite the test with LIT and FileCheck because the python approach has some limitations, e.g. timeouts. You can find examples in `lldb/lit/tools/lldb-mi/`.



================
Comment at: tools/lldb-mi/MICmdCmdGdbShow.cpp:369
+    const CMIUtilString strOption(vrWords[0]);
+    if (CMIUtilString::Compare(strOption, "pending")) {
+        if (!m_rLLDBDebugSessionInfo.SharedDataRetrieve("breakpoint.pending", m_strValue)) {
----------------
Following LLVM coding standarts, we should use early exits. In this case it might be like:

```
if (!CMIUtilString::Compare(strOption, "pending")) {
  // process error here
}
// success case here
...
```


https://reviews.llvm.org/D52953