[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Oct 22 16:26:34 PDT 2018

jingham added a comment.

This seems good to me, but Greg is more expert than I so I'd wait on his okay.

Comment at: source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1901-1907
+        dwarf->GetTypeList()->Insert(type_sp);
+        // Cache the type if it isn't context-specific.
+        auto &cache = dwarf->GetDIEToType();
+        if (exe_ctx.GetFrameSP())
+          cache.erase(die.GetDIE());
+        else
+          cache[die.GetDIE()] = type_sp.get();
You have to do this twice, maybe there should be a method to add the results to the DIE to Type map?


More information about the lldb-commits mailing list