[Lldb-commits] [PATCH] D53321: Code cleanup: Remove DWARFDebugInfoEntry::m_empty_children
Jan Kratochvil via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Oct 16 10:21:12 PDT 2018
jankratochvil marked 2 inline comments as done.
jankratochvil added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h:285-287
+ // It is zero if a DIE says it had
+ // children, yet it just contained
+ // a NULL tag.
> This comment is wrong. The DWARF encodes if a DIE has children in the .debug_info, but we may override this value if the DIE only contains an NULL terminating DIE.
> It should read something like:
> // If it is zero, then the DIE doesn't have children, or the
> // DWARF claimed it had children but the DIE only contained
> // a single NULL terminating child.
I cannot say it was wrong but I agree your rewording is much better.
More information about the lldb-commits