[Lldb-commits] [PATCH] D53297: [lldbsuite] Make the names of test classes unique

[Stella Stamenova via Phabricator via lldb-commits]

stella.stamenova created this revision.
stella.stamenova added reviewers: jasonmolenda, asmith.
Herald added subscribers: lldb-commits, kbarton, nemanjai.

If the names are not unique, the tests overwrite each other's results and logs. This also causes failures on platforms where the files are locked for writing.

The names of the class/test pairs *have to* always be unique. The easiest way to achieve that is to name each class differently (usually the same as the file name).


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53297

Files:
  packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py


Index: packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py
===================================================================
--- packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py
+++ packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestStopPCs.py
@@ -5,7 +5,7 @@
 from gdbclientutils import *
 
 
-class TestThreadSelectionBug(GDBRemoteTestBase):
+class TestStopPCs(GDBRemoteTestBase):
     def test(self):
         class MyResponder(MockGDBServerResponder):
             def haltReason(self):


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53297.169733.patch
Type: text/x-patch
Size: 570 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181015/0a2f0220/attachment.bin>