[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

[Stella Stamenova via lldb-commits]

Progress! The tests are running again and only a handful fail (some because of FileCheck, others for various other reasons).

http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/29816

It looks like there a number of tests that have failures unrelated to FileCheck, so anyone who has committed something recently should probably check if they broke a test or two.

-----Original Message-----
From: vsk at apple.com <vsk at apple.com> 
Sent: Friday, October 12, 2018 12:53 PM
To: reviews+D53175+public+09519a8f992e0e1a at reviews.llvm.org
Cc: Stella Stamenova <stilis at microsoft.com>; zturner at google.com; llvm-commits at lists.llvm.org; jmolenda at apple.com; lldb-commits at lists.llvm.org
Subject: Re: [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error



> On Oct 12, 2018, at 12:52 PM, Stella Stamenova via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> stella.stamenova added a comment.
> 
> The bots are now failing because lexists doesn't handle NoneType correctly:
> 
>    File "/lldb-buildbot/lldbSlave/buildWorkingDir/llvm/tools/lldb/packages/Python/lldbsuite/test/configuration.py", line 191, in get_filecheck_path
>      if os.path.lexists(filecheck):
>    File "/lldb-buildbot/virenv/lib/python2.7/posixpath.py", line 152, in lexists
>      os.lstat(path)
>  TypeError: coercing to Unicode: need string or buffer, NoneType found
> 
> I think get_filecheck_path should check if filecheck is set first before calling lexists:
> 
>  if filecheck and os.path.lexists(filecheck):
>          return filecheck

That sounds right. Would you mind committing the fix?

vedant

> 
> 
> Repository:
>  rL LLVM
> 
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Freviews.llvm.org%2FD53175&data=02%7C01%7CSTILIS%40microsoft.com%7Ca7ce141a6be247039d0308d6307c45d0%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636749707647902532&sdata=95dHTlsTC1R2KiUsMH3%2BV5vG0IUdFMFjN7snYNESzqA%3D&reserved=0
> 
> 
>