[Lldb-commits] [PATCH] D53175: [dotest] Make a missing FileCheck binary a warning, not an error

[Vedant Kumar via lldb-commits]

Does this look reasonable to you? I'm not sure how to test this.

diff --git a/zorg/buildbot/builders/LLDBBuilder.py b/zorg/buildbot/builders/LLDBBuilder.py
index 5a1b2e87..62152924 100644
--- a/zorg/buildbot/builders/LLDBBuilder.py
+++ b/zorg/buildbot/builders/LLDBBuilder.py
@@ -270,6 +270,7 @@ def getLLDBTestSteps(f,
             compilerPath = compiler
         for arch in test_archs:
             DOTEST_OPTS=''.join(['--executable ' + bindir + '/lldb ',
+                                 '--filecheck ' + bindir + '/FileCheck ',
                                  '-A %s ' % arch,
                                  '-C %s ' % compilerPath,
                                  '-s lldb-test-traces-%s-%s ' % (compiler, arch),
@@ -819,6 +820,7 @@ def getLLDBxcodebuildFactory(use_cc=None,
                   workdir=lldb_srcdir))
     DOTEST_OPTS = ' '.join(['--executable',
                             '%(lldb_bindir)s/lldb',
+                            '%(lldb_bindir)s/FileCheck',
                             '--framework', '%(lldb_bindir)s/LLDB.framework',
                             '-A', 'x86_64',
                             '-C', 'clang',

vedant

> On Oct 11, 2018, at 3:46 PM, Stella Stamenova via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> stella.stamenova added a comment.
> 
> The failing bots are not windows bots but Linux bots. It looks like you only updated the configurations for xcode.
> 
> I think the file that needs to be updated is:
> 
> zorg\buildbot\builders\LLDBBuilder.py
> 
> 
> https://reviews.llvm.org/D53175
> 
> 
>