[Lldb-commits] [PATCH] D53086: [PDB] Fix flaky `variables-locations.test` after PR38857

Aleksandr Urakov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Oct 11 03:34:34 PDT 2018

aleksandr.urakov added subscribers: zturner, jasonmolenda, labath.
aleksandr.urakov added a comment.

As for aligned stack cross-platform problems, I mean also problems with stack unwinding. They seem to appear on non-Windows too. It's because `x86AssemblyInspectionEngine` doesn't support stack alignment now. I've made some changes locally to fix it, but they are still raw to publish. The main idea is to save one more frame address (along with CFA) for every row of an unwind plan (I've called this AFA - aligned frame address), and add an analysis for `and esp, ...` etc. to `x86AssemblyInspectionEngine`. What do you think about a such approach?


More information about the lldb-commits mailing list