[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 10 11:27:54 PDT 2018

zturner added a comment.

If you plan to invest in more substantial changes in `ObjectFilePECOFF`, it might worth considering a complete re-write in terms of `llvm::object::coff`.  It has pretty comprehensive support for the PE/COFF spec, so it's just a matter of implementing `ObjectFilePECOFF` on top of it.

Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:810
+  std::lock_guard<std::recursive_mutex> guard(module_sp->GetMutex());
Does this actually need to be a `recursive_mutex`?



More information about the lldb-commits mailing list