[Lldb-commits] [lldb] r343718 - Adding skipIf to std::variant libc++ data-formatter test since get is not available before macOS 10.14

Shafik Yaghmour via lldb-commits lldb-commits at lists.llvm.org
Wed Oct 3 13:52:56 PDT 2018


Author: shafik
Date: Wed Oct  3 13:52:56 2018
New Revision: 343718

URL: http://llvm.org/viewvc/llvm-project?rev=343718&view=rev
Log:
Adding skipIf to std::variant libc++ data-formatter test since get is not available before macOS 10.14

Patch by Shafik Yaghmour

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.py

Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.py?rev=343718&r1=343717&r2=343718&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/variant/TestDataFormatterLibcxxVariant.py Wed Oct  3 13:52:56 2018
@@ -21,6 +21,8 @@ class LibcxxOptionalDataFormatterTestCas
     @skipIf(oslist=no_match(["macosx"]), compiler="clang", compiler_version=['<', '5.0'])
     ## We are skipping gcc version less that 5.1 since this test requires -std=c++17
     @skipIf(compiler="gcc", compiler_version=['<', '5.1'])
+    ## std::get is unavailable for std::variant before macOS 10.14
+    @skipIf(macos_version=["<", "10.14"])
 
     def test_with_run_command(self):
         """Test that that file and class static variables display correctly."""




More information about the lldb-commits mailing list