[Lldb-commits] [PATCH] D52461: [PDB] Introduce `PDBNameParser`

Mon Oct 1 05:05:50 PDT 2018

labath added a comment.

In https://reviews.llvm.org/D52461#1250555, @aleksandr.urakov wrote:

> I've tried to parse with it a name like
>
>   N0::`unnamed namespase'::Name
>
>
> and it can't parse it correctly. May be it just can't parse MSVC demangled names?

I expect the backqoutes are confusing it. If you try something without anonymous namespaces, it should work fine, and adding support for them shouldn't be too hard (though we may run also into problems with function pointers or other funky names, if they don't demangle the same way as with itanium).

Regardless of how this is exactly implemented, I think it's important to make the CPlusPlusLanguage::MethodName class understand these MSVC names, as this class is already used in a bunch of places. So, if it chokes on MSVC names, you're bound to run into more problems down the line.

> Unfortunately, I can't look at the tests right now, I have a vacation. I'll look at these a week later, ok?

That's fine. There's no hurry here..

Repository:
  rLLDB LLDB

https://reviews.llvm.org/D52461