[Lldb-commits] [PATCH] D52468: [PDB] Treat `char`, `signed char` and `unsigned char` as three different types

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Sep 27 16:02:24 PDT 2018


zturner accepted this revision.
zturner added a comment.

Can you change the description of the patch before submitting it?  It's hard to understand why the change does what the description says it does, because the description mentions 3 types of chars but the patch only handles 1.  I would just make the description say "handle char as a builtin type" or something


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D52468





More information about the lldb-commits mailing list