[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Sep 25 06:55:31 PDT 2018
labath added a comment.
In https://reviews.llvm.org/D52139#1243170, @teemperor wrote:
> Anyway, the actual issue is related Python 3: Arch Linux (and probably
> some other distributions that "already" upgraded to Python 3 as
> default) will launch Python 3 when the test script calls `python ...`.
> And for some reason in Python 3.7, we will not inherit our FD from our
> pipe to the subprocess, which causes this strange behavior when write
> to the unrelated FD number in ConnectToRemote. When I explicitly call
> Python 2.7 from the test, everything runs as expected.
> The python docs don't see to mention this change (and it seems like a
> bug to me), so I'm open for ideas how to fix this properly. In any
> case this problem doesn't block this review.
It's more like python 2 had a bug where it always inherited the file descriptor, and then python3 fixed that and introduced a special popen argument to control the inheriting behavior.
Back when we were designing this test, I demonstrated the necessary incantations for this to work on both python2 and 3 https://reviews.llvm.org/D49739?id=157310#inline-438290. It seems that did not make it into the final version..
More information about the lldb-commits