[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Sep 24 07:20:47 PDT 2018
teemperor added subscribers: aprantl, apolyakov.
teemperor added a comment.
> AFAIR, adding an exit(...) to ConnectToRemote won't solve this problem. The test will still be failing on Arch.
I was more hoping it would at least turn the deadlock into a fail,
this way I could at least run the test suit.
Anyway, the actual issue is related Python 3: Arch Linux (and probably
some other distributions that "already" upgraded to Python 3 as
default) will launch Python 3 when the test script calls `python ...`.
And for some reason in Python 3.7, we will not inherit our FD from our
pipe to the subprocess, which causes this strange behavior when write
to the unrelated FD number in ConnectToRemote. When I explicitly call
Python 2.7 from the test, everything runs as expected.
The python docs don't see to mention this change (and it seems like a
bug to me), so I'm open for ideas how to fix this properly. In any
case this problem doesn't block this review.
(I hope this comment shows up in Phabricator, as it seems
reviews.llvm.org is currently having some internal errors).
Am So., 23. Sep. 2018 um 01:03 Uhr schrieb Alexander Polyakov via
Phabricator <reviews at reviews.llvm.org>:
> apolyakov added a comment.
> AFAIR, adding an `exit(...)` to `ConnectToRemote` won't solve this problem. The test will still be failing on Arch.
More information about the lldb-commits