[Lldb-commits] [PATCH] D52376: [API][Swig] Overloaded functions for SBTarget

[Jim Ingham via Phabricator via lldb-commits]

jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

This patch changes the SB API.  We don't break binary compatibility with the SB API's, and especially not for something like GetInstructions/GetInstructionsWithFlavor, which are functions somebody out there is sure to be using.  See:

https://lldb.llvm.org/SB-api-coding-rules.html

I didn't know you could list multiple signatures in one type map, that part is cool!

But we don't allow removing SB API's, so the part where you remove a function and replace it with a defaulted argument one or straight up remove an API can't go in as is.  If you want to add a cleaner function, that's fine.

BTW, Sean isn't working on lldb anymore, so assigning him as a reviewer isn't going to do much good :-(


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D52376