[Lldb-commits] [PATCH] D51935: [LLDB] - Improve reporting source lines and variables (improved DWARF5 support).
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Sep 12 13:25:42 PDT 2018
clayborg added a comment.
In https://reviews.llvm.org/D51935#1232203, @grimar wrote:
> In https://reviews.llvm.org/D51935#1232195, @clayborg wrote:
> > Patch looks good. A few fixes mentioned in inlined comments. And I am unsure how the test suite will run with various compilers if they don't support the -gdwarf-5 flag. We might need to run obj2yaml on a binary and then yaml2obj it for the test to ensure we can run the test. We might be able to just symbolicate a few addresses in the test instead of requiring us to run something.
> What about using the llvm-mc? I can convert c++ code to the assembler I think.
> I'll try to investigate this problem tomorrow. Maybe we can just turn this test off somehow for that case.
Yeah, we want a test that goes along with this feature, but not sure how to test "does my compiler support this flag" in the test suite without reverting to llvm-mc or obj2yaml/yaml2obj
More information about the lldb-commits