[Lldb-commits] [PATCH] D51959: Add compatability version to liblldb in framework builds

[Alex Langford via Phabricator via lldb-commits]

xiaobai created this revision.
xiaobai added reviewers: clayborg, labath.
Herald added a subscriber: mgorny.

Building LLDB with xcodebuild sets the compatability version of liblldb
in LLDB.framework. Building the framework with cmake does not set the
compatability version, and so it defaults to 0.0.0. This is a discrepency in the
difference between the xcode build and the cmake build.

I tested this change by building without this patch. From the build tree I ran
`otool -L Library/Frameworks/LLDB.framework/Versions/A/LLDB` and got this:

  @rpath/LLDB.framework/Versions/A/LLDB (compatibility version 0.0.0, current version 8.0.0)

Did the same with this patch and the output contained this:

  @rpath/LLDB.framework/Versions/A/LLDB (compatibility version 1.0.0, current version 8.0.0)


https://reviews.llvm.org/D51959

Files:
  source/API/CMakeLists.txt


Index: source/API/CMakeLists.txt
===================================================================
--- source/API/CMakeLists.txt
+++ source/API/CMakeLists.txt
@@ -146,6 +146,7 @@
 if (LLDB_BUILD_FRAMEWORK)
   set_target_properties(liblldb
     PROPERTIES
+    SOVERSION "1.0.0"
     OUTPUT_NAME LLDB
     FRAMEWORK On
     FRAMEWORK_VERSION ${LLDB_FRAMEWORK_VERSION}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51959.164998.patch
Type: text/x-patch
Size: 369 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180911/ee85b74b/attachment.bin>