[Lldb-commits] [PATCH] D51934: [target] Change target create's behavior wrt loading dependent files.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: jasonmolenda, jingham, LLDB.
JDevlieghere added a dependency: D51859: [NFC] Turn "load dependent files" boolean into an enum .
JDevlieghere edited the summary of this revision.

When creating a target, lldb loads all dependent files (i.e. libs in `LC_LOAD_DYLIB` for Mach-O). This can be confusing, especially when two versions of the same library end up in the shared cache. It's possible to change this behavior,  by specifying  `target create -d <target>` these dependents are not loaded.

This patch changes the default behavior to only load dependent files only when the target is an executable. When creating a target for a library, it is now no longer necessary to pass `-d`. The user can still override this behavior by specifying the `-d` option. However, rather than a boolean you can now specify one of three values: `default`, `yes`, or `no`.

rdar://problem/43721382


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D51934

Files:
  packages/Python/lldbsuite/test/functionalities/target_create_deps/Makefile
  packages/Python/lldbsuite/test/functionalities/target_create_deps/TestTargetCreateDeps.py
  packages/Python/lldbsuite/test/functionalities/target_create_deps/a.cpp
  packages/Python/lldbsuite/test/functionalities/target_create_deps/a.mk
  packages/Python/lldbsuite/test/functionalities/target_create_deps/main.cpp
  packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py
  source/Commands/CommandObjectTarget.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51934.164897.patch
Type: text/x-patch
Size: 10901 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180911/ef8f6a4a/attachment.bin>