[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

[Aleksandr Urakov via Phabricator via lldb-commits]

aleksandr.urakov added inline comments.


================
Comment at: lldb/trunk/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:268-269
+
+std::unique_ptr<llvm::pdb::PDBSymbol>
+GetClassOrFunctionParent(const llvm::pdb::PDBSymbol &symbol) {
+  const IPDBSession &session = symbol.getSession();
----------------
zturner wrote:
> All file local functions should be marked `static`.
But this function is already belonging to `anonymous namespace`, what `static` actually means in C++. Do you think that it's still necessary?


Repository:
  rL LLVM

https://reviews.llvm.org/D51162