[Lldb-commits] [PATCH] D51162: [PDB] Restore AST from PDB symbols

[Ted Woodward via Phabricator via lldb-commits]

ted added a comment.

Another issue:

  auto context = symbol.getRawSymbol().getName();
  auto context_size = context.rfind("::");

...

  auto from = 0;
  while (from < context_size) {
   

context_size is size_t (from std::string::rfind), but on clang 5.01, "auto from = 0" makes from an int. The comparison on the next line generates a warning:
comparison of integers of different signs: 'int' and 'unsigned long' [-Werror,-Wsign-compare] on 64 bit Linux.

The "auto from = 0" should be "size_t from = 0", since auto can't determine the correct type.


Repository:
  rL LLVM

https://reviews.llvm.org/D51162